feat: adjust order of agent status and text box#2447
Closed
alexhancock wants to merge 2 commits into
Closed
Conversation
…rder The composer status/activity row moved above the text box, so: - The corner-mask CSS was pinned at bottom:2.5rem, calibrated for the old layout (composer pb-2 + 32px activity row below). With the row now above the composer and the composer padded to pb-5 (1.25rem), the masks no longer aligned to the composer's bottom edge, breaking the channel-composer-overflow overlay-mask tests. Repin to 1.25rem. - The activity row is now conditionally rendered (only on bot/typing activity). The date-divider test navigates to a channel with no such activity, so its incidental activity-row style assertions failed with element-not-found. Drop those assertions; they are unrelated to the date-divider behavior under test.
Author
|
This one ran into some other UX considerations like needing to move the messages which would be tricky. I've opened #2602 as a simpler option. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed a UI issue where the text entry box doesn't have consistent padding vertically and horizontally because the agent status bar (which is only active sometimes) sits below it. This makes the text box further away from the bottom than it is from the sides when the agent isn't doing anything and looked a bit off to me.
This change flips it so the agent status bar is above the text entry box, and the text entry box can sit in a more natural spot. It also subtly moves the messages up when the agent status bar is there so that they don't run under the status bar.
Before
After
Agent Active State